Repository navigation
fix(tools): transition tooling issues from the devnet rehearsal - #642
Merged
Merged
Conversation
…script cast 1.7.1 unlocks ETH_KEYSTORE for every `cast call`, so the direct-send path failed to read the proxy owner without a TTY. The reads now run with ETH_KEYSTORE unset; only `cast send` uses the wallet.
A modular FWSS deployment records no FWSS_VIEW_ADDRESS, and the proxy serves the view methods itself.
forge sets gas limits from its EVM simulation, which FEVM rejects for the deploys and runs out of gas for the execute call. Note the ~182M gas of the upgrade call for Safe signers.
…mmit The ledger test now reads the expected addresses from deployments.json and accepts the recorded dispatcher, which josuke.json lists between A1 and A5. The transition-script test seeds its scratch deployments.json from a v1.4.0 fixture instead of the committed file, which gains dispatcher records at A1.
A transaction that mined and reverted spends its nonce, so --resume stops and only a plain rerun deploys again.
wjmelements
approved these changes
Oct 21, 2026
github-project-automation
Bot
moved this from 🔎 Awaiting review
to ✔️ Approved by reviewer
in FOC
71 of 97 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rehearsed the v1.4.0 -> dispatcher upgrade (checklist path A) on a foc-devnet. The contracts behaved fine, but the tooling around them broke in four places, and each one would hit us on Calibnet too.
What's changed
--skip-simulation. Without it forge sets the gas limit from its EVM simulation: Lotus rejects both deploys, and the execute mines and reverts out of gas. The checklist notes the ~182M gas of the upgrade call so a Safe signer doesn't cap it, and the README says when--resumecan't recover a broadcastwarm-storage-announce-upgrade.shruns itscast calls withoutETH_KEYSTOREuntil Bump foundry once foundry-rs/foundry#17388 is fixed #621 lands, cast unlocked the keystore for them and the direct send failed without a TTYwarm-storage-manage-approved-provider.shfalls back toFWSS_PROXY_ADDRESSwhen noFWSS_VIEW_ADDRESSis recorded, which is the case for every modular deploytestLedgerAddressesreads the expected addresses fromdeployments.jsonand accepts the dispatcher, whichjosuke.jsonlists between A1 and A5. The transition-script test seeds from a v1.4.0deployments.jsonfixture instead of the committed file. Both failed as soon as the Mainnet A1 commit landed